Upgrading rubocop 0.18 to 0.19
Breaking0.18.1 → 0.19.1Breaking4New25Changed1Fixed26Other2
BreakingUpgrade verdict
4 breaking changes.
In plain terms
- Remove Ignore param from the Rails Output cop.
- Renamed FavorSprintf to FormatString and made it configurable.
- Renamed Offence to Offense.
- Renamed Style param of DotPosition cop to EnforcedStyle.
Must act Top 3 of 4 that need code or config changes
What you must change
Breaking4
Remove Ignore param from the Rails Output cop.
IgnoreOutputExclude/IncludeRenamed FavorSprintf to FormatString and made it configurable.
FavorSprintfFormatStringRenamed Offence to Offense.
OffenceOffenseRenamed Style param of DotPosition cop to EnforcedStyle.
StyleDotPositionEnforcedStyleAPI changes
Generated by DepDelta from published Ruby source. Not mixed with prose notes.
- removed:
property ProcessedSource.disabled_lines_for_cops: accessor - removed:
static method SourceParser.cop_disabled_lines_in(_) - removed:
static method SourceParser.each_mentioned_cop(_) - removed:
static method SourceParser.parse_with_parser(_, _) - added:
class CommentConfig - added:
const Options.EXITING_OPTIONS - added:
constructor CommentConfig(_) - added:
method CommentConfig.cop_enabled_at_line?(_, _) - added:
property CommentConfig.processed_source: reader - added:
property ProcessedSource.comment_config: reader
- added:
class COMMENT_DIRECTIVE_REGEXP < Regexp.new('\A# rubocop : ((?:dis|en)able)\b ((?:\w+,?)+)'.gsub(' ', '\s*'))
- removed:
class CorrectionNotPossible < Exception - removed:
class Offence - removed:
const Offence.SEVERITIES - removed:
constructor Offence(_, _, _, _, _ = …) - removed:
method Cop.add_offence(_, _, _ = …, _ = …) - removed:
method Cop.config_to_allow_offences() - removed:
method Offence.<=>(_) - removed:
method Offence.==(_) - removed:
method Offence.real_column() - removed:
method Offence.severity_code() - removed:
method Offence.severity_level() - removed:
method Offence.to_s() - removed:
property Cop.offences: reader - removed:
property Offence.column: reader - removed:
property Offence.cop_name: reader - removed:
property Offence.corrected: reader - removed:
property Offence.corrected?: reader - removed:
property Offence.line: reader - removed:
property Offence.location: reader - removed:
property Offence.message: reader - removed:
property Offence.severity: reader - removed:
set Cop.config_to_allow_offences(_) - changed:
method AutocorrectAlignment.check_alignment(_) → method AutocorrectAlignment.check_alignment(_, _ = …) - added:
class Offense - added:
const Offense.SEVERITIES - added:
constructor Offense(_, _, _, _, _ = …) - added:
method Cop.add_offense(_, _, _ = …, _ = …) - added:
method Cop.config_to_allow_offenses() - added:
method Offense.<=>(_) - added:
method Offense.==(_) - added:
method Offense.real_column() - added:
method Offense.severity_code() - added:
method Offense.severity_level() - added:
method Offense.to_s() - added:
method VariableInspector.find_variables_in_loop(_) - added:
property Cop.offenses: reader - added:
property Offense.column: reader - added:
property Offense.cop_name: reader - added:
property Offense.corrected: reader - added:
property Offense.corrected?: reader - added:
property Offense.line: reader - added:
property Offense.location: reader - added:
property Offense.message: reader - added:
property Offense.severity: reader - added:
property Team.updated_source_file: reader - added:
property Team.updated_source_file?: reader - added:
set Cop.config_to_allow_offenses(_)
- removed:
static method Syntax.offence_from_diagnostic(_) - removed:
static method Syntax.offences_from_diagnostics(_) - added:
class DeprecatedClassMethods < Cop - added:
class LiteralInInterpolation < Cop - added:
class StringConversionInInterpolation < Cop - added:
const DeprecatedClassMethods.DEPRECATED_METHODS - added:
const DeprecatedClassMethods.MSG - added:
const LiteralInCondition.BASIC_LITERALS - added:
const LiteralInInterpolation.LITERALS - added:
const LiteralInInterpolation.MSG - added:
const StringConversionInInterpolation.MSG - added:
method DeprecatedClassMethods.autocorrect(_) - added:
method DeprecatedClassMethods.on_send(_) - added:
method LiteralInCondition.on_case(_) - added:
method LiteralInInterpolation.on_dstr(_) - added:
method StringConversionInInterpolation.on_dstr(_) - added:
static method Syntax.offense_from_diagnostic(_) - added:
static method Syntax.offenses_from_diagnostics(_)
- removed:
method Output.ignore_paths() - removed:
method Output.matches_blacklist?(_) - added:
class ActionFilter < Cop - added:
class ScopeArgs < Cop - added:
const ActionFilter.ACTION_METHODS - added:
const ActionFilter.FILTER_METHODS - added:
const ActionFilter.MSG - added:
const ScopeArgs.MSG - added:
method ActionFilter.autocorrect(_) - added:
method ActionFilter.on_block(_) - added:
method ActionFilter.on_send(_) - added:
method ScopeArgs.on_send(_)
- removed:
class FavorSprintf < Cop - removed:
class SpaceAroundBlockBraces < Cop - removed:
const FavorSprintf.MSG - removed:
const SpaceAroundEqualsInParameterDefault.MSG - removed:
method CharacterLiteral.offence?(_) - removed:
method FavorSprintf.on_send(_) - removed:
method RegexpLiteral.max_slashes() - removed:
method SpaceAroundBlockBraces.on_block(_) - removed:
method SpaceAroundEqualsInParameterDefault.autocorrect(_) - changed:
method IndentationWidth.on_until(_) → method IndentationWidth.on_until(_, _ = …) - changed:
method IndentationWidth.on_while(_) → method IndentationWidth.on_while(_, _ = …) - added:
class ClassAndModuleChildren < Cop - added:
class DoubleNegation < Cop - added:
class FileName < Cop - added:
class FormatString < Cop - added:
class IndentArray < Cop - added:
class IndentHash < Cop - added:
class PercentLiteralDelimiters < Cop - added:
class SelfAssignment < Cop - added:
class SpaceBeforeBlockBraces < Cop - added:
class SpaceInsideBlockBraces < Cop - added:
const ClassAndModuleChildren.COMPACT_MSG - added:
const ClassAndModuleChildren.NESTED_MSG - added:
const DoubleNegation.MSG - added:
const FileName.MSG - added:
const FileName.SNAKE_CASE - added:
const SelfAssignment.OPS - added:
method AlignHash.on_send(_) - added:
method CharacterLiteral.offense?(_) - added:
method ClassAndModuleChildren.on_class(_) - added:
method ClassAndModuleChildren.on_module(_) - added:
method DoubleNegation.on_send(_) - added:
method FileName.investigate(_) - added:
method FormatString.on_send(_) - added:
method IndentArray.message(_) - added:
method IndentArray.on_array(_) - added:
method IndentHash.on_hash(_) - added:
method IndentHash.on_send(_) - added:
method PercentLiteralDelimiters.message(_) - added:
method PercentLiteralDelimiters.on_array(_) - added:
method PercentLiteralDelimiters.on_dstr(_) - added:
method PercentLiteralDelimiters.on_regexp(_) - added:
method PercentLiteralDelimiters.on_str(_) - added:
method PercentLiteralDelimiters.on_sym(_) - added:
method PercentLiteralDelimiters.on_xstr(_) - added:
method SelfAssignment.check(_, _) - added:
method SelfAssignment.check_boolean_node(_, _, _, _) - added:
method SelfAssignment.check_send_node(_, _, _, _) - added:
method SelfAssignment.on_cvasgn(_) - added:
method SelfAssignment.on_ivasgn(_) - added:
method SelfAssignment.on_lvasgn(_) - added:
method SpaceBeforeBlockBraces.on_block(_) - added:
method SpaceInsideBlockBraces.on_block(_)
- removed:
class OffenceCountFormatter < BaseFormatter - removed:
method JSONFormatter.hash_for_offence(_) - removed:
method OffenceCountFormatter.file_finished(_, _) - removed:
method OffenceCountFormatter.finished(_) - removed:
method OffenceCountFormatter.ordered_offence_counts(_) - removed:
method OffenceCountFormatter.report_summary(_, _) - removed:
method OffenceCountFormatter.started(_) - removed:
method OffenceCountFormatter.total_offence_count(_ = …) - removed:
property OffenceCountFormatter.offence_counts: reader - removed:
static property DisabledConfigFormatter.config_to_allow_offences: accessor - added:
class FuubarStyleFormatter < ClangStyleFormatter - added:
class OffenseCountFormatter < BaseFormatter - added:
const FuubarStyleFormatter.RESET_SEQUENCE - added:
method FuubarStyleFormatter.count_stats(_) - added:
method FuubarStyleFormatter.file_finished(_, _) - added:
method FuubarStyleFormatter.progressbar_color() - added:
method FuubarStyleFormatter.started(_) - added:
method FuubarStyleFormatter.with_color() - added:
method JSONFormatter.hash_for_offense(_) - added:
method OffenseCountFormatter.file_finished(_, _) - added:
method OffenseCountFormatter.finished(_) - added:
method OffenseCountFormatter.ordered_offense_counts(_) - added:
method OffenseCountFormatter.report_summary(_, _) - added:
method OffenseCountFormatter.started(_) - added:
method OffenseCountFormatter.total_offense_count(_ = …) - added:
property OffenseCountFormatter.offense_counts: reader - added:
static property DisabledConfigFormatter.config_to_allow_offenses: accessor
- removed:
class COMMENT_DIRECTIVE_REGEXP < Regexp.new('^.*?(\S)?.*# rubocop : ((?:dis|en)able)\b ((?:\w+,?)+)' .gsub(' ', '\s*'))